Sync eng/common directory with azure-sdk-tools for PR 15388#46632
Merged
Sync eng/common directory with azure-sdk-tools for PR 15388#46632
Conversation
…-github and pass the authtoken parameter
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…on for the new builds, but other than that, no impact
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Syncs eng/common pipeline templates with azure-sdk-tools PR 15388 by introducing a more flexible GitHub authentication flow that can either use a provided token (back-compat with azuresdk-github-pat) or auto-login via login-to-github.yml.
Changes:
- Add
AuthToken(andPushAuthToken) parameters and conditionallogin-to-github.ymlusage. - Switch token consumption to prefer template parameters and fall back to
GH_TOKENin multiple steps. - Update Git remote URL format for token-based pushes (
x-access-tokenstyle).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| eng/common/pipelines/templates/steps/git-push-changes.yml | Adds AuthToken, optional GitHub login step, and updates token usage for rate-limit metrics + push URL. |
| eng/common/pipelines/templates/steps/create-tags-and-git-release.yml | Adds AuthToken, optional GitHub login step, and updates GH_TOKEN env wiring. |
| eng/common/pipelines/templates/steps/create-pull-request.yml | Documents new auth behavior; adds AuthToken/PushAuthToken and threads token through push + PR creation. |
scbedd
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15388 See eng/common workflow